flamingchemist: a pink flower (flower)
Alex ([personal profile] flamingchemist) wrote in [site community profile] dreamscapes2012-01-17 07:38 pm
Entry tags:

(no subject)

I finished the layout set I was working on (although I never did fix that problem with the #content layer going all the way down, I apologize to anyone with OCD) and it needs to be tested!

The layouts are over here.

Thanks so much for any and all feedback. :)

[personal profile] lambchop_reads 2012-01-18 01:24 am (UTC)(link)
The #primary is positioned absolutely, which takes it out of the document flow and it cannot therefore push #content long enough to enclose it.

The only way you can position a content column absolutely is if you know the height to set on its container or if the only container you can "see" is the page itself, which is how the original style does it. As soon as you style one of the parent elements of #primary, you have a problem. The only way you can fix this is to change the way the column is positioned so it will push out #content to the correct length--or forget about applying styles to #content and stick to using body like the original does.
branchandroot: oak against sky (Default)

[personal profile] branchandroot 2012-01-18 03:25 am (UTC)(link)
You might check out how Tabula Rasa does columns. That's done with float, so a clearing element will push the container down far enough. There's no equivalent of clear:both for an absolutely positioned element.

[personal profile] lambchop_reads 2012-01-18 11:42 am (UTC)(link)
I didn't look too deep into the code, so I'm not going to promise you the #header styles are all fine as is, but I don't see anything that's an issue on a superficial glance.

#primary and #secondary are made into columns that sit side by side by having #secondary sit there with a wide margin that #primary is absolutely positioned on top of, offsetting down from the header by a fixed amount. You might be able to get relative positioning to work, but I didn't look at any layout other than two column, sidebar on the right.

You may have to float the two columns inside #content, and you already have a clearfix in there, so that should work okay (set overflow: hidden on #content if you do try that.)