Wanna patch?

[ninetydegrees]

We've had lots of lovely themes submitted in the last few days - thank you, designers! - and I thought it would be a good opportunity to ask if anybody wants to try and patch one but has never dared to or simply doesn't know where to start. Don't worry if you've never done that before or never written any code. I've been in your very shoes. :) I know it looks scary and complicated and impossible but I promise it won't look that way once you've done it. If you're on Windows, I can walk you through the process from start to finish. If you're on a Mac or Linux, I'm sure someone else will volunteer to help you (and the process isn't that different so I may be able to help as well or ask the right people questions). If you'd like to give it a try, simply comment. You can also PM me.

Comments

[laitaine]

Ah, okay, I wondered, which is why I asked.

Thanks!

[ninetydegrees]

It was a very good question!

Ready for the next step?

[laitaine]

Yep, I think so!

[ninetydegrees]

Great! Before I forget, would you mind making your layer viewable so that I can see it? I think it would make things easier for both of us but it's ok if you don't for now. If you're ok with it, just add this at the top:

layerinfo source_viewable = 1;

Then give me your layer number, please. For example one of mine is 4817 and since it's viewable you can see it at http://www.dreamwidth.org/customize/advanced/layersource?id=4817. See how it works?

[laitaine]

I don't mind at all, they're all source-viewable already.

The main layout is here:
http://www.dreamwidth.org/customize/advanced/layersource?id=125218&fmt=html

With a sample theme here:
http://www.dreamwidth.org/customize/advanced/layersource?id=125227&fmt=html

[ninetydegrees]

Oh I can see the theme but not the layout. :/

[laitaine]

Oh sorry, spelling fail on my part. It should work now.

[ninetydegrees]

It does, thank you.
I see you've done a very good job with the properties already. A few things though;
1) No empty color props in the theme.
2) Any non-color-related or non-font-related props should go into the layout layer.
3) I'm not sure I understand the creation of some props such as "color_module_header" and "color_module_header_background" when "color_module_title" and "color_module_title_background" already exist . Am I missing something?
4) All images need to be set via props, existing or new ones.

Also I'm not sure about hiding functionalities such as meta, mood, etc. I'll have to ask, though, so do nothing about these for now. Which is something you're actually NOT doing. I'm stupid tonight. Sorry about that.

[laitaine]

I'm so sorry for taking so long to sort these points. My life went crazy busy.

1) Sorted.
2) Sorted.
3) Uh, yes, you are missing a very important something: I am a moron. I have fixed things so that this fact is not so readily apparent ;)
4) Oh yeah, I'd forgotten about those. I meant to take those out - I wanted any images to be my own overrides not default. I figure it's best to keep with the standard images as default that everyone is familiar with to avoid confusion.

I think that's everything addressed, so.... next?

[ninetydegrees]

My turn to be sorry. I completely forgot to answer you and then work kept me very busy.

Unless I've missed something, the next step is to submit your layout to Dreamscapes so that it can get tested.

[laitaine]

No problem!

I ended up tinkering more and *did* add in the images after all (but set via props this time) and now I think I'm done so I have posted to dreamscapes for testing - eeep! Thank you so much for all your help so far!