Wanna patch?

[ninetydegrees]

We've had lots of lovely themes submitted in the last few days - thank you, designers! - and I thought it would be a good opportunity to ask if anybody wants to try and patch one but has never dared to or simply doesn't know where to start. Don't worry if you've never done that before or never written any code. I've been in your very shoes. :) I know it looks scary and complicated and impossible but I promise it won't look that way once you've done it. If you're on Windows, I can walk you through the process from start to finish. If you're on a Mac or Linux, I'm sure someone else will volunteer to help you (and the process isn't that different so I may be able to help as well or ask the right people questions). If you'd like to give it a try, simply comment. You can also PM me.

Comments

[foxfirefey]

I should learn how to convert styles! I know how to patch, just not the general process of conversion--I'm sure I could figure it out if I just looked at the already converted ones' patches, though.

I actually have one that I've been working on, but I worry because I don't think the author's done a CLA. But the post SAYS anybody could use their code for anything, so, I just don't know.

[ninetydegrees]

I'm sure it wouldn't be that hard to you. Long, maybe, but not hard. And yeah looking at other patches would help. If you tell me the level of conversion it needs I could probably link you to the patch that is the closest to what you need to do.

Hmm. I'm not sure it's enough for Denise. Have you tried contacted the author?

[foxfirefey]

Sometimes long but not hard is just what I need. Sometimes I feel like I want to do something, but don't have the energy for something that requires a lot of brain power! (Like, OMG, how do I fix these community posts from getting backdated and thus not showing up without KILLING EVERYTHING?)

If you know of a good example of turning-CSS-into-S2-style, I'm all ears.

I haven't poked her, I think, but to be honest, I'm half way to pretty much making something similar to that style (including some S2 changes), but different enough that we wouldn't have to worry. I like the look of it more than the actual implementation, and would be making lots more color themes for it.

[ninetydegrees]

If it's a color theme, all the ones we've got recently are really easy to convert. I can link you to my latest theme patch: http://bugs.dwscoalition.org/show_bug.cgi?id=2448

If it's a style, I think Sunday Morning is a good example: http://dreamscapes.dreamwidth.org/4835.html
http://bugs.dwscoalition.org/show_bug.cgi?id=1614

I'm looking forward to a Fey layout. ;)

[poulpette]

I was thinking of picking up one as a third bug for the June clean the little things hackaton. I need to vary to kind of bug I work on and get a first go at S2 layers.

I was looking at Snake & Boxes but don't want to step on anyone's toes so if someone else is already working on it I'm open to suggestions.
Guidelines/tips for converting would help too if you have them. Else I'll figure it out with patches from previous conversions.

[ninetydegrees]

As far as I know nobody's working on it. Afuna used to but she got too busy. I think you should ask her if she has any layer she could share.

As for guidelines, I don't know how much you know/don't know so I'll try to give you general pointers here but tell me what I need to explain, really.

-- Since S&B is based off Tabula Rasa, you can work on this without even having to start your Dreamhack. Simply create a layout layer, c/p Tabula Rasa layer then c/p the S&B CSS in function print_stylesheet (). You can see what I mean if you look at the source code for N. Oleanders for example (http://www.dreamwidth.org/customize/advanced/layersource?id=110067).

-- Then you need to clean the CSS up: remove any code which is already in the CSS of TB and therefore is redundant. Use background and font instead of font-family/font-size/etc. Rationalize/prettify the CSS. Remove tabs and trailing white space.

-- Replace fixed units with flexible units whenever possible/sensible.

-- Replace color values and font values with properties (found in Core). Put the hard coded values in a theme layer. It's ok if you can't replace everything. You can always create custom properties later.

-- Test, test, test and fix any issue (wrong placement, invisible text, overlapping, layout too big for a 1024x768 resolution, not working well when changing font size,...).

How's that for a start?

[baggyeyes]

I was going to try with a layout - maybe I should try with a theme first, because just the layout got me discouraged.

I'll most likely poke ya soon - this weekend is going to busy, busy, busy.

[ninetydegrees]

Yeah and all the layouts we have left are hard to convert.

I would love to see your name in dw_news as a new dev! I promise theme patching is not hard. Which OS are you on?

[ex_rising236]

The idea of patching scares me. But I'm willing to try at some point.

[ninetydegrees]

I was a total newbie the first time I did it. If I can do it, you can do it. And it feels good to patch your own themes. ;)
You know where to find me when you're ready and have some time.

Oh here's a link to a patch so that you can see what it looks like: http://bugs.dwscoalition.org/attachment.cgi?id=2652

Still scary? :)

[ex_rising236]

Not quiiite so scary, looking at it.

Do you come onto the IRC channel at all? I think I might have some time tomorrow morning or this evening or something. And yeah, the entire being able to patch my own themes thing sounds very appealing overall. :D Not that I'd only patch my own themes or anything, heehee.

[ninetydegrees]

Right? :)

No, I don't. I'm on Google Talk, though. Well, your morning probably isn't my morning. I live in GMT+2. Which operating system are you on? There may be a better person to help you out depending on your OS and they will probably be on IRC.

[laitaine]

Me me me! *waves hand in the air*

I really want to do something theme-y but I don't really know what to do. I've made various layouts for my LJ in the past and one of the first things I did when I moved in over here was create new layout and I'd like to share it with anyone who wants, but I don't really understand the style backend completely - I just hack around until things look how I want them too, mostly by adding lots of css. I don't know how I go from stuff-I-hacked-around-with-to-make-my-home-look-pretty to official-type-themes-that-other-people-can-use.

[baggyeyes]

OooOOOh. Very nice! I like your layout!

[laitaine]

Thank you!

[ninetydegrees]

Oh pretty! Before I try to explain, questions first: is your layout based off an existing style?

[laitaine]

Yeah, it's a theme layer for Tabula Rasa.

[ninetydegrees]

Very good! So you need to create a layout layer (not a theme layer). In this layer, c/p all the code for Tabula Rasa (http://www.dreamwidth.org/customize/advanced/layersource?id=551). Then add this:

layerinfo "type" = "layout";
layerinfo "name" = "Name";
layerinfo redist_uniq = "name/layout";
layerinfo author_name = "username";
layerinfo lang = "en";

set layout_authors = [ { "name" => "username", "type" => "user" } ];
set layout_type = "two-columns-left";

function print_stylesheet () {
"""

/* Name  */

/* C/P CSS HERE */

""";
}

And c/p your CSS where indicated.
Then we can get started on conversion.

[suncat]

I'll take a crack at it. I've recently put myself on a self-study course to learn S2 and all about layouts and styling here at Dreamwidth. So I'm just starting out. I'm also hitting points pretty frequently where I can't figure out what to do next in order to show/share whatever it is I'm working on in my own little space.

This sounds like a good way to learn some of this stuff and give a little back at the same time.

[ninetydegrees]

Patching themes is pretty simple. It has little to do with S2 and more to do with Perl and generating patches really. Here's what a patch file for a theme looks like: http://bugs.dwscoalition.org/attachment.cgi?id=2652

Think that could be something you want to learn how to do?

You've got a lovely layout BTW!

[suncat]

Sure, I'll try it. Your link goes to a couple of diff outputs. Don't know what they refer to, but that's what I'll learn, yes?

I've got a free account now. Do I need to upgrade to paid account in order to do this? I'm experiencing some confusion at the moment over what I can/cannot/should be able to do with the whole style system and S2 with only a free account. I was going to go post some questions over in the "getting started" journal.

And I have to say, yours is one of the most stunning layouts I've seen here since I joined Dreamwidth. Wonderful job!

[ninetydegrees]

Yes, it is. May I ask which operating system you're on?

No, you don't. Dreamwidth provides Dreamhacks aka a mirror installation of the Dreamwidth site to any developer who requests it, beginner or experienced. Over there, you can create any type of account you want and as many as you want without any codes so that you can test everything, create as many layers and styles as you need, etc.

If I remember well, free accounts can't create more than five custom layers and styles. They can have more layers and styles if they've been created by the system (Auto-generated Customizations layers and wizard-xxx styles) but not custom ones and if they already have five layers/styles, including system ones, they can't create more. So you can always use the ones you already have/have the system create more but you can't do it yourself.

Thank you! I've had it for quite a long time now and, to my utter despair, can't make it an official layout. The traditional wave pattern is mine but the rest isn't and isn't licensed to be shared. I haven't given up, though and am still looking for good replacements.

[dancing_serpent]

Do you need more people? I have to admit that I have no experiences coding, but I'm interested in learning.

[ninetydegrees]

We always need more people!

I have to admit that I have no experiences coding, but I'm interested in learning.

Welcome to the club! Which operating system are you on?

[dancing_serpent]

I'm on Windows XP, the 2002 Professional version.