Color Variations (Basic Boxes and Stepping Stones)

[branchandroot]

Theme name/layout: Basic Boxes / Tabula Rasa
Author: branchandroot
Layout info: Links to theme layers:

Burgundy
Leaf
Denim
Peach
Ecru


Theme name/layout: Stepping Stones / Tabula Rasa
Author: branchandroot
Layout info: Links to theme layers:

Gray
Shadows
Sunset
Dusky Rose
Chocolate
Olive
Pool

Notes: Themes contain full style sheets, but ideally only the color settings will need to be used.

Comments

[branchandroot]

It must be a bug specific to Denim, since Green doesn't show it; the wrong color getting put in for color_module_title, in the converted layer probably. Until I see the code, though, I won't know what to put the bug in for.

[testicle]

i am pasting only the theme-specific section -- everything up to but not including function print_stylesheet () { -- from what is linked above into the new theme layers i create.

the code in denim's theme-specific section above doesn't have color_module_title set.

i'm adding
set color_module_title = "#595D74";
for the preview pics.

[branchandroot]

*goes to fish around in the layer*

*frowns* Okay, I used color_entry_title for the module header background, so they'd be linked, but that is set to the pale blue in the Denim layer. And the preview function in Select Style shows me the pale blue background just as it should. I wonder if the conversion of the base style sheet has a variable that's overriding this. *goes to fish in that code*

Argh!

Afuna, there's going to be a problem with all these. My css was replaced by a local function that does not call the properties that I was actually using!

[afuna]

Oh eek, which local function?

[branchandroot]

The variable module_header_colors. That's why it's happening; if color_module_title_background is set, it works all right, but I had written the css to use the variable color_entry_title there so that the colors would stay the same basic shape in relation to each other unless someone set color_module_title_background, at which point the TR base sheet would override with a more specific css order for that color.

If the module background is set in most of the themes, the easiest thing to do is probably just to set color_module_title_background for Denim and Eggplant. That way module_header_colors and the css don't have to be edited.

[afuna]

Oh no! Okay I think the problem was that I didn't bother to check the stylesheets of the newer layers to make sure that they were the same as basic boxes green (http://www.dreamwidth.org/customize/advanced/layersource.bml?id=14985). Now that I'm aware of that, it's easy enough to fix.

http://bugs.dwscoalition.org/show_bug.cgi?id=1729, with patch (Tested quickly, and I think that makes it work the way you described. If that looks okay to you, can you review+? That will let me commit. )

Any idea if there's anything else that needs redoing?

[branchandroot]

*sighs* Okay, it look like, to make this work, it will need

set color_module_title_background = "#eae9ec";

And I'll see about a bug for the general issue, too. Why this is working in some and not others I really don't know yet.

[testicle]

ok; thanks.

the others all have color_module_title_background set in the theme.

afuna, does eggplant also have this problem? it does not set color_module_title_background explicitly.

[afuna]

Yep, eggplant also has this problem, I think. Will study it to see what colors it needs to have instead *g* I think Basic Boxes Green does, too. Possibly?