Color Variations (Basic Boxes and Stepping Stones)

[branchandroot]

Theme name/layout: Basic Boxes / Tabula Rasa
Author: branchandroot
Layout info: Links to theme layers:

Burgundy
Leaf
Denim
Peach
Ecru


Theme name/layout: Stepping Stones / Tabula Rasa
Author: branchandroot
Layout info: Links to theme layers:

Gray
Shadows
Sunset
Dusky Rose
Chocolate
Olive
Pool

Notes: Themes contain full style sheets, but ideally only the color settings will need to be used.

Comments

[testicle]

hey there, this is piranha's test account, tester and preview image maker.

a bug:

on stepping stones shadows and olive, the bottom nav bar, foreground and background colour are both the same, which makes the nav invisible.

a question:

on all the other new stepping stones layouts, is the nav background supposed to be black? it doesn't look particularly in tune with the rest of the palette.

also, on the original stepping stones purple, the visited link colour for the nav foreground is very, very light, so light that i can hardly see it on a mac.

@afuna -- i am putting these on hold until the questions are clarified.

[branchandroot]

I have already put in a bug for the bug; it is most certainly not supposed to be like that, the footer should be the same color as the header. That needs to be fixed in the layout base; the footer_background variable refers to the wrong universal color variable.

By nav background, do you mean the navigation module links? Profile, Reading, etc.? It is most certainly not supposed to be black, nor can I think of any reason it would be. It certainly isn't in my own Stepping Stones layers.

In Purple, the visited link color in the modules is supposed to be a light gray. They aren't hugely high contrast with the medium-dark purple sidebar background, but they should be quite readable.

[testicle]

no, not the links; the same place as the bug (which means, i guess, that it's the same layout base problem).

it looks like this, at the very bottom:


what colour should it be? i can dummy it for the preview pics. same as the header (ie. where journal title etc are located)?

[branchandroot]

*nods* Yeah; so, in this example, the footer should be purple. The bug is a little one, codewise, so I'm hoping it will be in the next batch of updates.

[afuna]

Already committed!

[testicle]

as always, you rock. :)

[testicle]

cool; i'll mock it up.

this fix will also fix the purple problem then. woohoo, we'll get all of these into the next code push!

[testicle]

basic boxes denim:

a number of the module headers don't have the right colour (they're dark instead of light).

[branchandroot]

What are you looking at? I am not seeing any of these problems in the layers linked here. They should all be the same dark blue text on a light blue background, except the modules that don't have any header.

[testicle]

profile and syndicate are light, the others are dark.

[branchandroot]

It must be a bug specific to Denim, since Green doesn't show it; the wrong color getting put in for color_module_title, in the converted layer probably. Until I see the code, though, I won't know what to put the bug in for.

[testicle]

i am pasting only the theme-specific section -- everything up to but not including function print_stylesheet () { -- from what is linked above into the new theme layers i create.

the code in denim's theme-specific section above doesn't have color_module_title set.

i'm adding
set color_module_title = "#595D74";
for the preview pics.

[branchandroot]

*goes to fish around in the layer*

*frowns* Okay, I used color_entry_title for the module header background, so they'd be linked, but that is set to the pale blue in the Denim layer. And the preview function in Select Style shows me the pale blue background just as it should. I wonder if the conversion of the base style sheet has a variable that's overriding this. *goes to fish in that code*

Argh!

Afuna, there's going to be a problem with all these. My css was replaced by a local function that does not call the properties that I was actually using!

[afuna]

Oh eek, which local function?

[branchandroot]

The variable module_header_colors. That's why it's happening; if color_module_title_background is set, it works all right, but I had written the css to use the variable color_entry_title there so that the colors would stay the same basic shape in relation to each other unless someone set color_module_title_background, at which point the TR base sheet would override with a more specific css order for that color.

If the module background is set in most of the themes, the easiest thing to do is probably just to set color_module_title_background for Denim and Eggplant. That way module_header_colors and the css don't have to be edited.

[afuna]

Oh no! Okay I think the problem was that I didn't bother to check the stylesheets of the newer layers to make sure that they were the same as basic boxes green (http://www.dreamwidth.org/customize/advanced/layersource.bml?id=14985). Now that I'm aware of that, it's easy enough to fix.

http://bugs.dwscoalition.org/show_bug.cgi?id=1729, with patch (Tested quickly, and I think that makes it work the way you described. If that looks okay to you, can you review+? That will let me commit. )

Any idea if there's anything else that needs redoing?

[branchandroot]

*sighs* Okay, it look like, to make this work, it will need

set color_module_title_background = "#eae9ec";

And I'll see about a bug for the general issue, too. Why this is working in some and not others I really don't know yet.

[testicle]

ok; thanks.

the others all have color_module_title_background set in the theme.

afuna, does eggplant also have this problem? it does not set color_module_title_background explicitly.

[afuna]

Yep, eggplant also has this problem, I think. Will study it to see what colors it needs to have instead *g* I think Basic Boxes Green does, too. Possibly?

[afuna]

Hmm, okay I'm slightly confused, sorry. There seem to be several different versions of the CSS, because in, e.g., green and peach, module-header uses color_module_title_background. Whereas in denim, it uses color_entry_title. Which should I go with?

[branchandroot]

Oh man, I was really out of it if I missed that. *thinks*

Okay, let's do this. Instead of entry_title, in all cases let's just go with color_module_title_background. That's what the majority of the themes seem to use already, and we won't have to change as much. I think I must have somehow just missed Denim for this change, on my way through the last time. So for bug 1729, Denim should get

set color_module_title = "#595D74";
set color_module_title_background = "#eAe9eC";

added, and the base css can stay as is.

[afuna]

Done. Put up a patch in http://bugs.dwscoalition.org/show_bug.cgi?id=1729, in case you want to see :)

Basically:

Changes the module header bg and fg for BB Green
Adds a module header bg and fg for BB Denim
Adds a module header bg for BB Eggplant (which, hm, actually matches the module bg, but anyway!)

And the rest look fine as they were.

[afuna]

Marking this done, as we've comitted all the themes, but still need to figure out what's up with the basic boxes issue *g*

(And I think that'll be it?)