1 New Style w/ 1 Theme: Practicality (tabula rasa)

[timeasmymeasure]

I finally got this one done!

Layout Name: Practicality
Layout Info: http://www.dreamwidth.org/customize/advanced/layerbrowse?id=158205
Layout Source: http://www.dreamwidth.org/customize/advanced/layersource?id=158205
Layout Preview: http://www.dreamwidth.org/customize/preview_redirect?layoutid=158205

And a theme for color context:
Theme Name/Layout: Warmth / Practicality
Layout: Info || Source || Preview

I was wondering if someone could help me crack the reason for my recalcitrant column setups? I've managed to set the two-column right/left. However the one-column version keeps the 15em default width in the modules and the three-column right/left/sides setups look a bit off to me.

Otherwise, I think it's pretty much done. If you see anything else off, please let me know, I'd appreciate it! Thanks!

Comments

Re: Patching

[timeasmymeasure]

Ooooh okay! Thanks!
That works now =D

The userlite text looks great. I do like that you have it display block instead of inline.

Same background color and no border then?
Yep :)
That way it doesn't look like it's part of the entries.

Re: Patching

[ninetydegrees]

The userlite text looks great. I do like that you have it display block instead of inline.

Great. This is the new default for all styles.

That way it doesn't look like it's part of the entries.

This any better?

Edit: management links as text: http://system.ninetydegrees.hack.dreamwidth.net/

Also I've added all the themes to my Dreamhack so if you want to check that all colors are all right (particularly control strip and pop-ups colors) please do.

Re: Patching

[timeasmymeasure]

Oh yeah, much. Though is there a way to reduce the padding on the navlinks? There's a lot of space between the titles and the navlinks and the navlinks and the bottom of the header.

Will the navlinks remain in the modules in default view/previews?

Re: Patching

[ninetydegrees]

You're right. I could apply the same margin as for the subtitle... better?

As you wish. If you'd rather have them at the top by default I'll set them so. You're the boss. ;)

Re: Patching

[timeasmymeasure]

LOL xD
It honestly wouldn't really matter to me where they go. I suppose we can keep them in the modules as that seems to be the default for most other styles. Users can place them in the header if they'd like :)

You're right. I could apply the same margin as for the subtitle... better?
Perfect.

Re: Patching

[ninetydegrees]

Ok.

Final check: I'm checking colors and poster names (in entries and page summaries) are pretty hard to read in Choco Craze and Night Light (it's dark on dark) which made me notice that you sort of have contradicting code:

.ljuser a b {
color: $*color_header_background;
}

.entry-poster a {
color: $*color_entry_title;
}

The first piece overrides the second one meaning that poster names uses color_header_background and not color_entry_title. Help?

Re: Patching

[timeasmymeasure]

Ah...bugger. Thanks for catching that.
Alright. Would it be easier to delete the code?
That way no matter what, unless a user customizes their entry background and links in horrible ways, it still shows up clearly.

Re: Patching

[ninetydegrees]

I think keeping the second bit would be ok because the entry_title should always be visible over the entry background.

Edit: making styles work with light on dark and dark on light themes is one of the harding part of making styles for me.

Edit2: also have to change some colors in the Nav Strip for the same reason.

Re: Patching

[timeasmymeasure]

I think keeping the second bit would be ok because the entry_title should always be visible over the entry background.
Sound logic. Let's go with that. For the navstrip too :)
Thanks.

Edit: making styles work with light on dark and dark on light themes is one of the harding part of making styles for me.
I'm always freaking out about this because I work with dark on light much more than light on dark. Sometimes it feels like shots in the dark.

Re: Patching

[ninetydegrees]

Thanks.

Thank you. It's always great to work with you. And easy. And fast. I think I just have to make the previews and I can put this up for review. *bg*

I'm always freaking out about this because I work with dark on light much more than light on dark. Sometimes it feels like shots in the dark.

:) Same here.

Re: Patching

[timeasmymeasure]

By the end of our sessions, the layout's half yours anyway =D
I learn a lot from the back and forth, more than I would if I just stared at the code and tried to fix things myself.

I think I just have to make the previews and I can put this up for review.
Oh, this is always exciting! Makes me long for a code push :p

Re: Patching

[ninetydegrees]

:) I learn a lot. You pay a lot of attention to details which in turn makes me pay much more attention to them too.

Easiest preview ever: http://bugs.dwscoalition.org/show_bug.cgi?id=3056
I'm looking forward to it as well!

Committed!

[ninetydegrees]

http://changelog.dreamwidth.org/748936.html

*high fives*

Re: Committed!

[timeasmymeasure]

WOOT!!
*high fives back*

Thanks for this!

Re: Committed!

[timeasmymeasure]

Hey, random question:
Do I contact support if I'm having issues setting up a dreamhack?

Re: Committed!

[ninetydegrees]

Support isn't the best place, I think. You can e-mail Sophie (her e-mail address is at http://hack.dreamwidth.net/maintainers.shtml), ask questions at dw_dev_training and on the dev IRC channel (see http://wiki.dwscoalition.org/notes/IRC).

Also, if you haven't seen them already, Sarken's written a newibe guide for Mac users (http://sarken.dreamwidth.org/1747903.html) and I've made one for Windows users (http://wiki.dwscoalition.org/notes/Newbie_Guide_for_Windows_People_Working_on_Minor_Bugs).

Edit: and, of course, you can ask anybody you know has a hack questions.

Re: Committed!

[timeasmymeasure]

Thanks so much! I'll check out your guide.
Though fair warning, you may be the person I know who has a hack, sorry :p

Re: Committed!

[ninetydegrees]

Though fair warning, you may be the person I know who has a hack, sorry :p

Not a problem at all! :)