timeasmymeasure (![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
timeasmymeasure) wrote in ![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png)
dreamscapes2010-07-30 04:56 pm
timeasmymeasure) wrote in dreamscapes2010-07-30 04:56 pm
Entry tags:
Layout: Compartmentalize / Tabula Rasa
Theme name/layout: Compartmentalize / Tabula Rasa
Author:timeasmymeasure
Layout Info: http://www.dreamwidth.org/customize/advanced/layerbrowse?id=136090
Layout Source: http://www.dreamwidth.org/customize/advanced/layersource?id=136090
Layout Preview: http://www.dreamwidth.org/customize/preview_redirect?layoutid=136090
Image info: No added images
Additional info: If anything's off, please let me know. It's the first time I've coded tabula rasa from the theme layer. Working on some color themes for the layout; will post later. Based off of the CSS only version here.
Author:
timeasmymeasure Layout Info: http://www.dreamwidth.org/customize/advanced/layerbrowse?id=136090
Layout Source: http://www.dreamwidth.org/customize/advanced/layersource?id=136090
Layout Preview: http://www.dreamwidth.org/customize/preview_redirect?layoutid=136090
Image info: No added images
Additional info: If anything's off, please let me know. It's the first time I've coded tabula rasa from the theme layer. Working on some color themes for the layout; will post later. Based off of the CSS only version here.
no subject
Still loving the style and very happy you've posted it. :)
no subject
-- The default Tabula Rasa code is a bit different from what you have in your layer. I guess it's because it's changed between the moment you coded your style and now (with the code push and all that) so simply copy/paste it again to have the most up-to-date version.
-- Same thing with function EntryPage::print_comment_partial (Comment c) { }. It's been changed a bit as a result of the recent code push.
-- You have edited a few functions to add new classes but you're not styling these elements, it seems. So I don't understand what the point is.
-- You don't need to set properties in the part which is your layout if you're not changing their values. For example, sidebar_width is already set to 15em in Tabula Rasa so no need to repeat that in your style because it will inherit this value. Same thing with properties already set in the Core layer. For example: set text_tags_item_sep = ",";
-- Same idea but with CSS. For example:
a:hover {
color: $*color_page_link_hover;
}
repeats what's already in TB:
a:hover { $page_link_hover_colors }
-- You seem to have a few empty CSS properties e.g.
.poster-ip {
display: ;
}
They should be removed?
-- You may know that already but when you have decimals you can remove the zero; so .5em instead of 0.5em. I'm saying this because the less code, the lighter the stylesheet, the better.
-- I think this would be better be set via properties than via CSS:
a:active, a:visited {
color: $*color_page_link;
}
If you set the colors for this to the same value in your color themes instead, it will let users who need or like to have links change colors still be able to do so easily with your default theme still looking the way you want it. Not an obligation but food for thought, ok?
-- I would also let users have a top nav because some users really need/like it but, again, not an obligation. That's my personal take on this.
-- Any reason why you set a fixed width to the contextual pop up? I'm afraid it's not going to scale well and will prevent people using large font sizes from using it.
no subject
Thank you for all the review, I definitely appreciate it. I'll review and let you know when I've made the corrections. I may have some questions with that too :)
ETA:
-- You may know that already but when you have decimals you can remove the zero; so .5em instead of 0.5em. I'm saying this because the less code, the lighter the stylesheet, the better.
-- I would also let users have a top nav because some users really need/like it but, again, not an obligation. That's my personal take on this.
-- You seem to have a few empty CSS properties e.g.
-- The default Tabula Rasa code is a bit different from what you have in your layer. I guess it's because it's changed between the moment you coded your style and now (with the code push and all that) so simply copy/paste it again to have the most up-to-date version.
-- You don't need to set properties in the part which is your layout if you're not changing their values. For example, sidebar_width is already set to 15em in Tabula Rasa so no need to repeat that in your style because it will inherit this value. Same thing with properties already set in the Core layer. For example: set text_tags_item_sep = ",";
-- Same thing with function EntryPage::print_comment_partial (Comment c) { }. It's been changed a bit as a result of the recent code push.
-- You have edited a few functions to add new classes but you're not styling these elements, it seems. So I don't understand what the point is.
I'll get those color themes posted as soon as possible =D
Thanks again for all the feedback!
no subject
- Copy/Pasted the CSS, hopefully I didn't mess anything up.
Hmm. I think I haven't explained it well. You need to c/p the whole layer, not just the CSS. Here's the layer: http://www.dreamwidth.org/customize/advanced/layersource?id=551
Everything that is above:
# ---------------------------------------------------------------------------- #
# ---------------------------------------------------------------------------- #
# ---------------------------------------------------------------------------- #
layerinfo "type" = "layout";
layerinfo "name" = "Compartmentalize";
should be replaced with it.
To prevent any problem, I would duplicate your current layer in a new layer so that you don't lose it should anything go wrong.
- When I remove the sidebar width and text_tags_item_sep they dissapear, i.e., the tag separation/metadata text dissapears and the sidebar blends with the entire page. This may of course be a mistake I made higher up in the code.
I can't answer that yet. It could be because some code is missing but I'm not sure. Let's leave that for later.
-I think I'll go with your suggestion and leave these to the patcher (word?), I'm not sure how to go about correcting this. I was biting my nails through most of this layer, wouldn't want to mess it up now :|
Oh I see you got these from laitaine, right? The point of these it to add more CSS classes to style, such as .expand-link which she uses to style the expand link on collapsed comments. If you don't plan on styling them, then you don't need the functions and you can remove them.
no subject
Yeah, I did get the layer stuff from other tabula rasa submissions, including lataines, by comparing and contrasting- this way I could try and learn the functions and things- and then used my CSS to change the design of the thing. Trial and error, it's kind of how I learned HTML/CSS in the first place ;)
Thanks again!
no subject
There may be a few extra things left but otherwise it's perfect. Thanks a lot for being willing to work on this. This will made the patcher's work much easier.
no subject
no subject
Really happy you like it =)
no subject
no subject
Feedback, please?
I'm working on patching this and here's the testable layer I came up with: http://www.dreamwidth.org/customize/advanced/layersource?id=135800
I've mostly tidied things up a bit and removed empty lines or code which was already in TB.
1) Would you please use it and tell me if anything's not as it should be?
2) The day names were almost invisible in the archive page table so I've changed their color but it may not be what you wanted. Thoughts?
(BTW, the way you designed the archive page is fantastic. I think I've never seen it look so good, clear and easy to use.)
3) I've added some code to make sure your style could work with all layouts (one column, two columns right, etc.). Does it look like you want when you switch layouts?
4) I've added/modified some code in entries and comments because the header was overlapping the userpic in edge cases (long subject, big font size, small screen resolution), notably setting the userpic padding to pixels so that the header could have a workable margin, and modifying padding in comments a bit. Does it look ok to you?
5) I've also added some code to make the userpic display-able on the left. I wasn't sure how you wanted that to look so feel free to do something different or tell me what it should be like.
6) I've tested the style with metadata at the top (an option available in all styles) and it looked fine to me but I'd like to make sure it looks fine to you. :)
And that's it I think. For now, anyway. :)
Re: Feedback, please?
1) So far, so good. I can't find anything that glares out at me.
2) Thank you, glad you like it. The changes are completely fine :) It still works with it, and if it increases readability that's even better.
3) Tested all the set-ups, they look good, no major problems. Though the One Column setup seems to retain the 15em sidebar width. I found that if I just deleted the set width in the options it fixed itself.
4) Tested it with a long heading. The userpic was nudged down a bit when set to right placement but I don't think that's a problem. It did the same thing when I set the userpic to the left, again not really a problem.
5) Your adjustments are fine :)
6) It looks kind of cool (w/ metadata above text) when it's aligned with the userpic like that. I like it.
The feedback is absolutely no bother at all =D
Thanks again for patching this!
Re: Feedback, please?
Yeah, it does look a bit awkward but there's a bug to change the way one column works so I'll leave like this, if you don't mind.
Would you want that to be the default display?
Edit:
More thorough testing led me to modify a few things again to make sure text in hover pop-ups and the calendar (again) was visible/readable in all themes. If you want to have a look and make sure everything's all right, you can create an account on my Dreamhack and select your style in Customize.
Second edit: also added a clear:both in the entry footer because it was causing the icon links to be misaligned in some cases (I totally noticed this by accident) and reduced the userpic's bottom padding a bit because it was causing a bigger space as a result.
Re: Feedback, please?
PATCHED!
Edit:
http://bugs.dwscoalition.org/show_bug.cgi?id=2953
Now I can *high fives*! The review queue is insanely long right now but I'm pretty sure your style will go live with the next code push. ^_^
Re: PATCHED!
Thank you for all the hard work you put in =D
no subject
^_^
no subject
Oh yay!!
That's awesome!
Thank you so much for all your work and input =D
no subject