2 Themes

[sven]

Hi again! Just themes this time (:

Theme name: Steele & Beechy For Bases.
Author: malionette
Layout info: Steele | Beechy
Image info: Beechy has one image: bg

Live previews are up! See Steele and Beechy?

edit k got rid of patches

Comments

[foxfirefey]

I lurve Steele. ::has a thing for greys::

[baggyeyes]

I just tried this - is there any way of allowing designers to put into their layer code something to disable the multi-column selector if the design doesn't allow for it? I just tried to add columns, and wow, did that look horrible.

[sven]

the 3-columns and 2-column left options are already disabled on the layout selection page. i'll have to ask around to see if they can disable them on the customize options page too i guess

thanks for the reminder

[sven]

yay! glad you like it (:

[ninetydegrees]

Hi Malionette,

There's already a bug filed for the header bkg issue: http://bugs.dwscoalition.org/show_bug.cgi?id=1887

:)

[sven]

In the layout layer Bases here's what it says:

var string header_background = generate_background_css ($*image_background_header_url, $*image_background_header_repeat,
$*image_background_header_position, $*color_module_title);

this is what it should say:

var string header_background = generate_background_css ($*image_background_header_url, $*image_background_header_repeat,
$*image_background_header_position, $*color_header_background);

--------

and if you guys are editing the layout layer too could you delete this line for me?:

if ($*image_background_header_url == "" ){} else { print """ <style type="text/css"> #title, #subtitle, #pagetitle {display: none} </style> """; }

[ninetydegrees]

I can't do it as it's not relevant to this bug but you can ask Support to file a bug for you or file it yourself.

[sven]

ah it's ok it's not too important

[yvi]

I am pretty sure you can also file one :) If not, I will try to remember filing it today.

[ninetydegrees]

I would if I knew what this bug was for and what I should write in the subject and desc fields so please do.

[sven]

it's just to remove a bit of code

it says if the length of the header url is greater than zero, make all the text in the header journal disappeAr.

[afuna]

I'm pretty sure that once it's official, the layout options in the customize options are gone, replaced by the images in the select journal style area.

I *think* that instead of "property use layout_type", doing:

property string layout_type {
des = "Layout Type";
values = "|none|one-column|One column|two-columns-left|Two columns (Sidebar on Left)|two-columns-right|Two columns (Sidebar on Right)|three-columns-sides|Three columns (Sidebars on either side)|three-columns-left|Three column (Sidebars on Left)|three-columns-right|Three column (Sidebars on Right)";
}


and editing the values, will fix it for non-official themes. Will have to look a bit more.

[sven]

ok (: thanks!

[ninetydegrees]

Hi again, it seems to me these are done being teste and are ready to be patched. Is that correct?

[sven]

Yeah, they're fine.

[ninetydegrees]

Cool. Two questions about Beechy: the header's supposed to be yellow or white? (The code is different from the preview). Do you meant for margin-top to be flexible? I think it looks a bit strange on layouts without subtitles as the white line is thicker than 1px.

[sven]

Yeah it's yellow sorry I edited it to white while I was testing the header background colour glitch.

Which margin-top are you talking about?

[ninetydegrees]

This one: #entries, .page-entry .entry, .page-tags .tags-container, .page-archive #archive-year, .page-month #archive-month, .page-reply .entry-title
{border-top: 2.417em solid #589d96; margin-top: 0.083em;}

[sven]

(Did someone edit colour variables in Bases? My themes are looking a bit off. )

That's meant to be there. It doesn't look weird on my screen (it's just a 1px line)?

[ninetydegrees]

As far as I know, only two changes have been made on this layout:
- use $*color_header_background instead of $*color_module_title as the header background color
- set the text color of #subtitle to $*color_page_title

I meant did you mean for it to be in a proportional unit instead of a fixed one (which means it will change size as the font or the layout changes)? If I preview my layout (http://900degrees.dreamwidth.org/?s2id=97423) it looks thicker than on yours.

[sven]

Ok thanks.

I'm not seeing yours as any thicker. And it should be proportional since the base layout's borders and margins were all proportional.

[ninetydegrees]

Got it. Thanks!

[ninetydegrees]

Last question before this gets committed to the code: can you confirm that you've created Beechy's background image?

[sven]

yes i did every pixel of it

[ninetydegrees]

:) Awesome. Thank you!