dreamscapes | Tabula Rasa / Funky Circles / Atomic Orange

Entry tags:

Tabula Rasa / Funky Circles / Atomic Orange

Edit: this is now live and can be selected from Customize Style. Original layers and pics are no longer available.

Theme name/layout: Atomic Orange / Funky Circles / Tabula Rasa
Author: 900degrees
Layout info: theme layer
Image info: still six images, still mine.
Preview: http://900degrees.dreamwidth.org/?s2id=90601

Probably my last one. I had to do something orange...

Can anybody think of a title?

Flat | Top-Level Comments Only

Electric Orange? Electric Sheep? Crushed Orange?

Quite striking.

Agree with the quite striking. (No suggestion for the name from my end, though :-))

:)

BTW is there anything I can do to get these committed faster?

Hmmmmmm. I think if you submitted them as patch form, that would take away some of the latency, and make it easier for reviewers to get at them (it also means that I can review your patch, instead of getting someone else to review it for me!)

If you're interested, you can get the DW code by doing this (you need it so that you can generate a "real" patch):

http://wiki.dwscoalition.org/notes/Working_on_a_Styles_Bug

then:
1.edit dw-free/bin/upgrading/s2layers/funkycircles/layout.s2
2. copy-paste your style modifications (I'm assuming you have the modified layout layer already?)
3. if on linux, type "hg diff". If on Windows, right click, and do "diff". That will generate a patch that we can use to easily test your changes

And ummm let me know if you run into any problems with it!

So I edited the file but I don't know how to generate the patch. There is no 'diff' in the right clik menu.

Edit: I can click on 'Visual Diff' then open a file in some kind of editor called KDiff3 but I don't know what's the next step.

Edited 2009-09-24 19:54 (UTC)

Hi! Sorry for the late responsel. I fell asleep (darn timezosens *rueful*)

I'm not on Windows, but let me see if I can get instructions from someone in the know...

ETA:

Hmm, okay, can you try typing "hg diff" from the commandline?

If that doesn't work, here's another method that involves more steps:
1.) commit your changes (don't worry, this will only affect your own repository)
2.) view the log and export the changes as a patch/diff
3.) roll back the changes (so that you have a clean slate again

Edited 2009-09-25 02:49 (UTC)

Either it doesn't do anything or I didn't do it correctly... The second method seems to work. I get something which starts like this:

# HG changeset patch
# User 900degrees
# Date 1253852156 -7200
# Branch production
# Node ID 7b9905c3460fddc1e101c245b29277bcc14026b2
# Parent  712a215e4459f298acc4d90396d43f1389eda7a5
Fix reply page in Funky Circles

diff -r 712a215e4459 -r 7b9905c3460f bin/upgrading/s2layers/funkycircles/layout.s2
--- a/bin/upgrading/s2layers/funkycircles/layout.s2	Thu Sep 24 18:16:29 2009 +0000
+++ b/bin/upgrading/s2layers/funkycircles/layout.s2	Fri Sep 25 06:15:56 2009 +0200
@@ -314,7 +314,8 @@
         }
 
 .entry,
-.page-entry .comment {
+.page-entry .comment,
+.page-reply .comment {
     background-color: transparent;
     border: none;
     position: relative;
@@ -410,7 +411,8 @@
         padding: 1.2em 2em 2em 2em;
         }
 
-    .page-entry .comment-wrapper.has-userpic .comment .contents {
+    .page-entry .comment-wrapper.has-userpic .comment .contents,
+    .page-reply .comment-wrapper.has-userpic .comment .contents {
         padding: 2em;
         }

Is it correct?

Yup!

Oh, if you want to try the first method again, make sure you're doing it from within the dw-free checked out directory. But otherwise, the second method does the same thing, just with more clicks.

Oh that worked then. ;)

What do I do with the .patch file?

Okay, since that's a new theme, you need to do the following:

1.) file a new styles bug. I use this template.

Note in the summary/title that it's a theme for Funky Circles -- Theme: Atomic Orange (Funky Circles) works --

In the description, include a link to your entry on dreamscapes.

2.) then go to http://bugs.dwscoalition.org/show_bug.cgi?id=680, and leave a note with a link to your bug (so it's easy to find)

I actually did the patch for the CSS fixes for the Reply page (http://bugs.dwscoalition.org/show_bug.cgi?id=1884) so could you explain the process for this one too, please?

I'll do the themes right after. Can I do all my themes at the same time or is it better do theme one by one (but then do you have to wait till the first one is committed/live)?

Also, I suppose I have to create a Bugzilla account. Yes?

Okay, and this step applies to the themes too:

1.) Go to http://bugs.dwscoalition.org/createaccount.cgi (there's a link from the front page, in case you ever need to find it again) and create your zilla account

2.) go to bug 1884, assign it to yourself, needs two things:
a. put your email address in the assignee
b. set the status to assigned

(I usually just use this script: http://afunamatata.com/greasemonkey/dreamwidth_bug_grabber.user.js)

3.) Upload your patch.

There will be a link "Upload a new attachment" under the table which would contain attachments(if there had been previous in that bug)

So upload your patch there, and then check the "patch" checkbox, set the commit and review dropdowns to "?"

(I just use this: http://afunamatata.com/greasemonkey/dreamwidth_patch_upload_.user.js)

And hmm. I think that's it! Then someone will come and review/commit it. (You'll receive three emails when that happens, so umm. be prepared, heh. I think it's possible to filter them out, but I haven't done that myself.)

Ok I think I did everything correctly. Thanks a lot for your very clear explanations!

Oh, can you answer my question about themes (all at the same time or one by one?)?

Hmmm. I think all at the same time is good, but one bug for each layout, in case you end up submitting for multiple layouts in the future.

I've just realized I don't know how to upload the images. Do I have to rename and zip them like you did in http://bugs.dwscoalition.org/show_bug.cgi?id=1769?

Yeah, that's a good idea. (Whoever is testing can do it, but it's easier this way, heh)

Ok one more question: I noticed that the extensions of the image files are .jpg in the theme layer whereas the images are actually .png files. I know that's probably because Tiny Pic appends the .jpg extension to their URLs no matter what the original format is but I'm not sure what I should save them as. On my computers they're .png files and have the .png extension, not .jpg or .jpg.png (which is what you get is you save them from the layout).

Edit: I went ahead and left them as .png files.

Edited 2009-09-26 17:25 (UTC)

Belatedly, but just confirming that yup, .png is the way to go.

OH OY.

Sorry sorry sorry sorry. I misread this as being on the tweaks you wanted to your layout, not the theme layer *facepalm*.

Though (and hi, it's me again), the idea is still basically the same. The biggest issue holding back the committing of any of the themes is the lack of time on the part of people who can convert it into patch form -- are you interested in doing so? *G* (The fact that it's already in theme layer form, though means it shouldn't take me too long, actually, but again... time!)

And then after that is just waiting for the image preview to be done!

I definitely am interested in doing so (working on my fixes too). I've got a problem though. I'm on Windows so I downloaded Tortoise as explained. When I try to clone the dw-free repository I get LiveJournal's repo. I double-checked the repository URL and I did enter http://hg.dwscoalition.org/dw-free. Everything works fine for the non-free repo.
Help?

So very strange. If you delete and try again, does it still pull the LJ repo?

Is that just that it's producing "Some LiveJournal site" because no-one's got around to changing it to "Some Dreamwidth site"?

Yes. May it be that I get some out-of-date version of the dw-free repo? The layer directories are: bob, classic, cleansimple, deardiary, digitalmulitplex, etc.

Wait. I checked the option 'use pull protocol to copy metadata' and now I get both repos (LJ and DW layers).

Edit: Hmm. The file format is all wrong: I get .s2.i

Edit 2: and if I check 'use uncompressed transfer' I get the old repo again. :/

Edit 3: \o/ I added what I assumed was the latest revision number (712a215e4459) and it worked.

Edited 2009-09-24 19:12 (UTC)

s2.i thing is mercurial-specific internal housekeeping files. They should only be in .hg/...., and you can ignore them.

Latest revision... oh! I know exactly what happened: it was pulling an old version, and you did exactly the right thing. We'll update the instructions. Thakn Thank you for catching that!

(Even stranger about it pulling the LJ repo, is that LJ is all SVN, not mercurial)

Electric Orange sounds very nice. Maybe Atomic Orange?

Atomic Orange sounds better.

Sold! ;)

I like it!!

Thanks!

Claimed at http://bugs.dwscoalition.org/show_bug.cgi?id=1893

Flat | Top-Level Comments Only

Tabula Rasa / Funky Circles / Atomic Orange

no subject

no subject

no subject

no subject

Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

Re: Problem #2

no subject

no subject

no subject

no subject

no subject

no subject

no subject

no subject

no subject

no subject

no subject

no subject

no subject

no subject

no subject