If you haven't set a color, removing empty lines like set blahblahblah = ""; would make patching easier and faster.
Is there a specific preference for themes that set a color to be empty or blank where normally there would be a color?
For example, the Gradients themes I submitted for Crisped depend somewhat on blanking out/removing the background color for the entry titles, entry headers, and module headers so that the gradients will be visible. The way we did that was setting set blahblahblah = "none"; instead of set blahblahblah = "#NNNNNN";—though I realized after submitting that set blahblahblah = "transparent"; might work just as well, and might also be easier on the end user. We didn't really want to completely code background colors out of the CSS, in case the user wanted to have backgrounds in some places and gradients in others, instead of gradients everywhere.
Is it also acceptable to edit for corrections when a theme is submitted but still under review? It occurred to us that some of the s2 color value choices that we originally made in the Gradients themes should be changed around for usability and easier user customization. (We realized that repurposing the currently "blanked" s2 border color for the drop shadow color makes more sense than matching the drop shadows to the s2 entry title color. It's not exactly a giant thing to fix, but we feel a little dumb now.)
no subject
Is there a specific preference for themes that set a color to be empty or blank where normally there would be a color?
For example, the Gradients themes I submitted for Crisped depend somewhat on blanking out/removing the background color for the entry titles, entry headers, and module headers so that the gradients will be visible. The way we did that was setting
set blahblahblah = "none";instead ofset blahblahblah = "#NNNNNN";—though I realized after submitting thatset blahblahblah = "transparent";might work just as well, and might also be easier on the end user. We didn't really want to completely code background colors out of the CSS, in case the user wanted to have backgrounds in some places and gradients in others, instead of gradients everywhere.Is it also acceptable to edit for corrections when a theme is submitted but still under review? It occurred to us that some of the s2 color value choices that we originally made in the Gradients themes should be changed around for usability and easier user customization. (We realized that repurposing the currently "blanked" s2 border color for the drop shadow color makes more sense than matching the drop shadows to the s2 entry title color. It's not exactly a giant thing to fix, but we feel a little dumb now.)