I really like how these look! I just have a few things to clear up.
What's the logic for having two separate layouts with differring levels of customisability? Or maybe to rephrase, what's the logic behind restricting the customisability of this layout?
Make sure when you re-submit when you're ready for someone to patch it to add it to the site you pull out any colour definitions from the layout layer. Our policy is to only make colour definitions in theme layers. Also make sure you indicate which theme you want to be the default theme for your layout.
I also feel a bit weird about defining the custom text content; in my opinion, this should be left blank by default and left up to the user to decide whther or not he/she wants to use it. I kind of feel the same about the link text ('# voices', etc), especially since they're pretty specific. I feel like these should be pretty generic, but that might just be me.
re: 3.: If you really want the permalink to persist (even though it and the comment link point to the same place), what you could do is change the function CommentInfo::print() to remove the "} else {" block around the permalink.
no subject
What's the logic for having two separate layouts with differring levels of customisability? Or maybe to rephrase, what's the logic behind restricting the customisability of this layout?
Make sure when you re-submit when you're ready for someone to patch it to add it to the site you pull out any colour definitions from the layout layer. Our policy is to only make colour definitions in theme layers. Also make sure you indicate which theme you want to be the default theme for your layout.
I also feel a bit weird about defining the custom text content; in my opinion, this should be left blank by default and left up to the user to decide whther or not he/she wants to use it. I kind of feel the same about the link text ('# voices', etc), especially since they're pretty specific. I feel like these should be pretty generic, but that might just be me.
re: 3.: If you really want the permalink to persist (even though it and the comment link point to the same place), what you could do is change the function CommentInfo::print() to remove the "} else {" block around the permalink.