Colour theme: Funky Circles: Light on Dark

[cesy]

Theme name/layout: Funky Circles / Light on Dark
Author: cesy
Layout info: http://www.dreamwidth.org/customize/advanced/layersource?id=76707
Image info: Uses images from Funky Circles / Dark Purple (specified in the layout info).

Ideally this needs the image converting as well, but it looks okay as-is.

Edit: I've now fixed this to use the Dark Purple images, so it's ready for testing and submission.

Comments

[ninetydegrees]

If every background thing's black then you can't see the images anyway so you might as set them all to blank:

set image_background_page_url = "";

and so on.

/2 cents

[cesy]

I just figured out that I can set the main page background to purple, and it still works in terms of light-on-dark readability, but means I can re-use your purple images. Hope that's okay.

[ninetydegrees]

I think you forgot to set the entry background color or did you want it to be purple too?

Edit: There's no userpic background either?

About the background, why not go for a dark gray? I don't think the original purple's dark enough for what you want to do.

Edit2: Oh I think I know what the problem is. I think you've only set the color properties which are from Tabula Rasa and none of the color properties which are specific to this theme. In Customize Style, you have colors in Style and Misc. I've already reported that because I think it's very confusing.

Meanwhile, you can use http://www.dreamwidth.org/customize/advanced/layerbrowse?id=funkycircles/darkpurple to see the list of all the stuff you have to set.

Last Edit (I promise!) My bad. You did set some FC-specific colors. But it seems to me you've forgotten some colors. Y/N?

[cesy]

Thanks for the tip. I've fixed the entry background now, and deliberately left the userpic background white. I'm hoping that the rest of the properties should inherit sensibly, so I don't need to set all of them individually. Is that right?

[ninetydegrees]

I'm not sure it works like that because there are no colors in the layout layer. They're all set in the theme so there won't be any inheritance. I looked at other themes for other layouts and they have all the color properties.

[cesy]

Okay, I think I've got them all now. I'd missed the collapsed sections on Misc in Customize. In the process of doing that, I've discovered another problem - several of the modules overflow their boundaries. Any idea how to fix that, or should I just make the module border and background be the same as the page background so you can't tell?

[ninetydegrees]

I only know what's causing this but I don't know why and, well, to "fix" it you've got to change the values:

.module li {
margin: .5em;
}

.module-calendar td {
padding: .3em;
}

[cesy]

Okay, I've added a bit more CSS (as it was still overflowing in certain places with that, and one or two other bits needed margin or padding), and I think it's better now, though it should probably be tested in other browsers and screen sizes.

[ninetydegrees]

Hi again Cesy,

I think this one is ready to be patched too, isn't it?
However, since you've made your layer, there has been some modifications to Funky Circles to fix the overflowing issues you noticed so I'm not sure which of your CSS is necessary and which no longer isn't.
For reference, here's how the layout looks like without any CSS modifications: http://www.dreamwidth.org/customize/preview_redirect?themeid=89119

[cesy]

That looks fine, so do go ahead, and sorry it took so long to get back to you.