Layout submission: Lefty

[sarken]

Layout: Lefty
Author: sarken
Layout info: Green Party Preview - Green Party Info - Green Party Source
Pinko Preview - Pinko Info - Pinko Source
Militant Preview - Militant Info - Militant Source
Image info: N/A
Additional info (for layouts): Full color info for Green Party and Pinko. For Transmogrified. Doesn't use the layout stylesheet. Supports one column and two column page setups. It'll probably need some minor changes to fit official guidelines, and I'm happy to provide an opinion if you have any questions or doubts, but not particularly interested in changing the code myself.

Comments

[branchandroot]

Snazzy!

[boundbooks]

So pleased to see this submitted!

[dancing_serpent]

Oh, I like this! And the colours for Green Party and Militant are very pretty!

[owl]

Using Green Party, it's so snappy!

[ninetydegrees]

Yay and I love the new theme too!

[milkymoon]

I really like 'Pinko', and will install it when I have time. :)

[forthwritten]

I've just worked out the wordplay on Lefty! :D

Lovely layout - I think I saw this when you were using it on your own journal and really liked it then, so I'm glad it will become a site layout.

[eosrose]

I will totally snag Pinko. It's lovely!

[allchildren]

Love it. One thing for whoever makes it official: ordered lists skew too far left out of the entry box. Like so: http://grab.by/dSoW

[sarken]

Oops! That's probably because I left out inside on the ordered list. It should be:
.entry-content ol {
list-style: decimal-leading-zero inside;
}

[allchildren]

Perfect! Thank you!!

[sarken]

Thank you for catching it! I've gone and fixed it so no one else will run into that problem.

[miami_tea]

I'm usually very fickle with themes but I love this one too much to change it! It's great! :D

There is one little issue I've seen though: On pages where there are less than posts than the max post per page number the first post will look a bit wonky because the padding created by the next page arrow isn't there.

Better explained: On a page with less than 10/20 posts stuff looks weird.

And to illustrate: http://imgur.com/k27zU

[sarken]

Yeah, I'm sorry about that! I can't really fix it, since, like you said, the the arrow isn't there (nor is the div that contains it). Maybe whoever patches it can figure something out.

[momijizukamori]

Hideously belated, but now that the style is live, we've noticed a problem with the previous/next arrow alignments - basically, if the sidebar is longer than the content, the placement of the bottom arrow ends up on top of the sidebar itself. Which basically means moving the arrows - I suggested keeping the left-align, but having them sit above and below the entry section proper (instead of having the negative margin that puts them in the sidebar), and 90d counter-suggested with maybe keeping the top nav with the negative-margin, but moving the bottom one in under the entries.

Given that it's your design, we thought it should be your stylistic call :)

[sarken]

I think I like 90d's suggestion, since I am not a huge fan of next/previous links being over the entries. But I'm not actually sure what the arrows look like now that it's live -- they're not working in Safari 6.0.4, Chrome 26.0.1410.65, or Firefox 20.0 on OS X 10.8.3. Here's a screen shot of what I see when I go to the Select Journal Styles page and click the image to preview it on my journal (it looks the same no matter which browser I am using).

[momijizukamori]

Yeaaaaaaaaah, I realized when I went to work on the bug that I made a mistake in my original patch (mostly that 4em is not remotely close to 48px when the font size for the element base is 1px), so I'm working on making them the right size too as I fix the other problem

[sarken]

No problem! I just wanted to make sure you were aware of it. Thanks for all your work.

[momijizukamori]

You're welcome :) I'm kind of mentally smacking myself for not catching that earlier, but the review queue for layouts got really backed up, so by the time it got committed I'd forgotten most of what I'd done originally.

[momijizukamori]

And just as follow-up - the patch hasn't been committed yet, but after it is and goes live, the layout'll look like this :)