rosecarmine: (Default)
Alexandra C. ([personal profile] rosecarmine) wrote in [site community profile] dreamscapes2014-04-15 11:08 pm

Layout: Gold leaf

Name: Gold leaf
Author: [personal profile] rosecarmine
Image info: Backgroung image from subtlepatterns.com (license), metadata, tag images by p.yusukekamiyamane.com (license)

Layout layer: Info | Source | Syntax Highlighted
Theme layer: Info | Source | Syntax Highlighted | Preview
ninetydegrees: Drawing: a girl's pale face, with a yellow and green stripe over her right eye (Default)

[personal profile] ninetydegrees 2014-04-15 08:49 pm (UTC)(link)
I've only taken a quick look for now but this looks really nice. Really, congrats!
A few things I've noticed: I think you can use font_sources for the font face, you have some hardcoded image URLs which should be (custom?) properties then set in your theme, you don't need to do the _child thing since you're making a whole new layout layer. You can just add your custom properties to the usual group.
And a question: is there any way you can put userpic back after subject, metatypes and time? This way screenreader users can get this information first instead of info about userpics. Maybe using float?

About the top of page link, I think what you did is good; although I would add alt/title text. If you want it to be an option, then you just create one --in Presentation let's say; maybe a boolean one like you did already-- and in Page::print, you do an if/else too.
Edited 2014-04-15 20:51 (UTC)
ninetydegrees: Drawing: a girl's pale face, with a yellow and green stripe over her right eye (Default)

[personal profile] ninetydegrees 2014-04-16 05:43 pm (UTC)(link)
I saw them hardcoded in the layout layer's CSS and in another, in the theme layer.

Was the harcoding in the CSS in a public style? If so, it needs to be fixed.

Should all added images, including bullets, be replaceable in the wizard?

Generally, yes. If there are images you don't think should be customizable -- or other options -- you can hide them from the interface using noui = 1; in the property definition but you really need a good reason for that.

Regarding the entry userpic, I tried different variants and this is the one that worked the best.

Can you explain what the issues were if you left it afterwards? Was the problem having them on opposite sides? This is an accessibility issue so we really need to see if we can work something out.

Edit: also wanted to say you have nothing to apologize about. You've done a *terrific* job.
Edited (blockquote was terrible... and I'm crap at typing today!) 2014-04-16 17:51 (UTC)
ninetydegrees: Drawing: a girl's pale face, with a yellow and green stripe over her right eye (Default)

[personal profile] ninetydegrees 2014-04-16 06:24 pm (UTC)(link)
Ok trying to find a solution for userpics, I wrapped subject, metatypes and time in a div then userpic and poster in another then floated both divs, and used display: table-cell and vertical-align: bottom for userpic and poster the way we do it on site-styled icons pages --maybe w/ a little bit of margin-top so it sits really at the bottom-- and it seemed not to be a bad idea but that was just at first glance. Have you tried this?
ninetydegrees: Drawing: a girl's pale face, with a yellow and green stripe over her right eye (Default)

[personal profile] ninetydegrees 2014-04-16 10:15 pm (UTC)(link)
Oh this is a special case. There's partially hardcoded (see the variable at the beginning?) because they use images which are already stored on DW's servers, but stored in a different location that images would normally be as they're from a style which can't be redistributed. In brief, it's the simplest way to access them short of copying them in another folder.

Oh you can basically add CSS classes into existing HTML or add DIVs if you need new CSS classes. Some things can be moved to different classes (for example I often move print_tags out of .entry .footer and into .contents because I can't have the spacing I want otherwise). You can also reorder some minor elements as long as this won't be problematic for screenreader users, as you've seen here.

You're most welcome! There are so many things you only learn by experience (the userpic distortion was something users noticed and we had to fix it afterwards :) so I'm glad I can put mine to good use.
ninetydegrees: Drawing: a girl's pale face, with a yellow and green stripe over her right eye (Default)

[personal profile] ninetydegrees 2014-04-18 06:44 pm (UTC)(link)
You're really haven't, I promise. It's all part of the process and you've been awesome.
kanagosa: My dragonsona (Default)

[personal profile] kanagosa 2014-04-16 12:44 pm (UTC)(link)
Works in Chrome here too! And it's gorgeous! I'd love to use this one. :3
kanagosa: My dragonsona (Default)

[personal profile] kanagosa 2014-04-17 11:54 am (UTC)(link)
You're welcome. It's got just the right amount of fancy without being over the top.
ninetydegrees: Drawing: a girl's pale face, with a yellow and green stripe over her right eye (Default)

[personal profile] ninetydegrees 2014-04-16 06:08 pm (UTC)(link)
One more thing about userpics, but totally different from the other thing: hardocding width and height is going to distort non-square userpics or userpics which are smaller than your targeted width and height. Also I think this overrides the userpic_style options (please tell me if I'm wrong). Would you be ok with using either the 'small' or 'smaller' setting instead?
ninetydegrees: Drawing: a girl's pale face, with a yellow and green stripe over her right eye (Default)

[personal profile] ninetydegrees 2014-04-16 10:22 pm (UTC)(link)
Commenting as I notice things (feel free to leave these unanswered unless you have questions): for the three sidebar_border colors I think it would nicer if the names could be more descriptive (like you actually did in the descriptions). The idea is that because you made the style you know immediately what 1, 2 and 3 correspond to but someone who's not familiar with it and see this in the CSS would have to scroll up to the descriptions to understand what they're about, especially when they're used for secondary selectors like .userpic. See what I mean?
wendelah1: Mulder and Scully in a snow globe (Default)

[personal profile] wendelah1 2014-04-16 08:59 pm (UTC)(link)
It's pretty! I'd use it.
calliopes_pen: (day_dream_girl1 admire Donna)

[personal profile] calliopes_pen 2014-04-17 04:43 pm (UTC)(link)
This looks fantastic! This is definitely a layout that I would love to use.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2014-04-23 05:57 am (UTC)(link)
I don't have any implementation notes, but I want to say, this is gorgeous!
forthwritten: stained glass spiral (Default)

[personal profile] forthwritten 2014-05-05 02:21 pm (UTC)(link)
Very nice!

Check the poll images though - I think you have to hardcode the height of the bars.
got_swagger: (TA:  Agent Hill)

[personal profile] got_swagger 2014-06-10 10:31 pm (UTC)(link)
This is lovely and it's definitely a layout I'd use!