foxfirefey: A guy looking ridiculous by doing a fashionable posing with a mouse, slinging the cord over his shoulders. (geek)
foxfirefey ([personal profile] foxfirefey) wrote in [site community profile] dreamscapes2013-04-23 03:08 pm
Entry tags:

Layout tweak suggestion?

I don't know if this is the proper thing to do, but I have a suggestion for Ciel! Basically, it has a min-height for comments, which is fine, but when it comes to collapsed comments, I feel it's a bit excessive and gets in the way.

If we change this:

.comment {
    min-height: 138px;
}


To this so the min-height only targets the full comments:

.comment-wrapper.full .comment {
    min-height: 138px;
}


I feel like it would improve things greatly--there is enough padding in the collapsed comment areas to keep it from being too crowded, and not having 100 or so pixels of extra space around each collapsed comment really helps out in scanning them to see the flow of conversation.
oldsoldiersneverdie: (Default)

/Momiji

[personal profile] oldsoldiersneverdie 2013-04-23 11:03 pm (UTC)(link)
This sounds a-okay to me. And that might have even been my fault (not rememebering that collapsed inherits a bunch of stuff from full comments.........)
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)

[staff profile] fu 2013-04-24 05:16 am (UTC)(link)
I think that is reasonable!
carisma_sensei: (Default)

[personal profile] carisma_sensei 2013-04-24 03:19 pm (UTC)(link)
I agree! Helps things look a lot cleaner :3
carene_waterman: An image of the Carina Nebula (Default)

[personal profile] carene_waterman 2013-04-25 10:55 pm (UTC)(link)
I always dislike measures in pixels on any element that contains content.

If it were min-height: 8.625em on the full comments, even if a user has icons off and a really small font size on a wide screen, they will get a nicely scaled down to their use-case min-height.

If a user has 16px font, they see the same thing as 138px.

ETA: the icons are floated in this layout (I got worried they were absolutely positioned) and no container has overflow: auto or overflow: hidden on it. The min-height is making sure the icon doesn't overflow. Changing the min-height to ems would require the overflow fix. If that's the only design function of the min-height, I'd just switch it out for overflow: auto.
Edited 2013-04-26 14:06 (UTC)